Python 3.7 #310
Merged
Python 3.7 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* async is now a reserved word in python3.7 * Rename async function to enqueue * Rename all async_ functions to enqueue_ * Rename Async class to AsyncTask * Updates the docs.
Replaces async occurrences with alternatives
Fix a typo I introduced in groups.rst
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 89.88% 90.38% +0.49%
==========================================
Files 44 43 -1
Lines 2866 2838 -28
==========================================
- Hits 2576 2565 -11
+ Misses 290 273 -17
Continue to review full report at Codecov.
|
KlaasH
added a commit
to azavea/pfb-network-connectivity
that referenced
this pull request
Sep 9, 2019
"async" is a reserved word in Python 3.7, so django-q had to rename their thing. Unfortunately they didn't make documentation or CHANGELOG changes to go with the code changes and releases, so see Koed00/django-q#306 and Koed00/django-q#310 for more information.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes support for Python 2 and older Django versions.
Renames
asynctoasync_taskto prevent reserved keyword conflicts in Python 3.7