Add option for acknowledging failed tasks (globally and per-task) #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a task fails with an exception, it is retried until it succeeds. This is contrary to what is said in the documentation: under the "Architecture" section, heading "Broker" it says that even when a task errors, it's still considered a successful delivery. Failed tasks never get acknowledged however, thereby being retried after the timeout period. See also issues Koed00#238 and Koed00#194. This patch adds an option to acknowledge failures, thereby closing issue Koed00#238. Issue Koed00#194 would require some more work. The default of this option is set to `False`, thereby maintaining backwards compatibility.
Codecov Report
@@ Coverage Diff @@
## master #298 +/- ##
=========================================
+ Coverage 90.2% 90.31% +0.1%
=========================================
Files 44 44
Lines 2839 2870 +31
=========================================
+ Hits 2561 2592 +31
Misses 278 278
Continue to review full report at Codecov.
|
Koed00
approved these changes
Mar 13, 2018
|
Thank you! Issue #238 can now be closed. And thank you for creating this package, I found it when looking for a more lightweight solution without a dependency on redis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a task fails with an exception, it is retried until it succeeds. This is contrary to what is said in the documentation: under the "Architecture" section, heading "Broker" (link) it says that even when a task errors, it's still considered a successful delivery. Failed tasks never get acknowledged however, thereby being retried after the timeout period. See also issues #238 and #194.
This patch adds an option to acknowledge failures, thereby closing issue #238. Issue #194 would require some more work. The default of this option is set to
False, thereby maintaining backwardscompatibility.