Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the path location where Django-Q is inserted. #297

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Changing the path location where Django-Q is inserted. #297

merged 4 commits into from
Mar 13, 2018

Conversation

Eagllus
Copy link
Collaborator

@Eagllus Eagllus commented Feb 27, 2018

Some imports can no longer be done by just import signing instead
from django_q import signing should be typed

Fixes: #199

@Eagllus Eagllus requested a review from Koed00 February 27, 2018 15:20
@codecov-io
Copy link

codecov-io commented Mar 13, 2018

Codecov Report

Merging #297 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #297      +/-   ##
==========================================
- Coverage    90.2%   90.19%   -0.02%     
==========================================
  Files          44       44              
  Lines        2839     2835       -4     
==========================================
- Hits         2561     2557       -4     
  Misses        278      278
Impacted Files Coverage Δ
django_q/__init__.py 100% <ø> (ø) ⬆️
django_q/tasks.py 99.72% <100%> (ø) ⬆️
django_q/cluster.py 90.97% <100%> (ø) ⬆️
django_q/status.py 97.4% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c657731...430c177. Read the comment docs.

Eagllus added 4 commits March 13, 2018 09:21
Only Python 2.x is having problems with this import so for now
the fix would be to move the import to the function that uses cluster
@Eagllus Eagllus requested review from Koed00 and removed request for Koed00 March 13, 2018 08:44
@Koed00 Koed00 merged commit 65afb63 into Koed00:master Mar 13, 2018
@Eagllus Eagllus deleted the fix_199 branch March 13, 2018 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants