Updates Travis to test for Django 2 and the LTS versions #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 92.74% 92.67% -0.08%
==========================================
Files 42 42
Lines 2758 2758
==========================================
- Hits 2558 2556 -2
- Misses 200 202 +2
Continue to review full report at Codecov.
|
In Django 1.10 MIDDLEWARE_CLASSES is set to deprecated and is removed in Django 2.0. The SessionAuthenticationMiddleware is also removed from Django 2.0 and was already unconditionally enabled in Django 1.10.
This will not fix anything related to Django 2.0 but will allow MAC users to run Django-Q allowing tests to be run locally.
By reverting django.core.signing to Django 1.11.8 version Django-Q works This is not designed as a 'good' solution just to show where I think the problem is.
Django 2 compatiblity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.