-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop unsupported php versions #337
Merged
akerouanton
merged 4 commits into
KnpLabs:master
from
akerouanton:drop-unsupported-php-versions
Dec 7, 2018
Merged
Drop unsupported php versions #337
akerouanton
merged 4 commits into
KnpLabs:master
from
akerouanton:drop-unsupported-php-versions
Dec 7, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasmure
reviewed
Dec 7, 2018
7f31eca
to
5b60a8f
Compare
This also adds PHP v7.2/7.3 to Travis build matrix
b6bdeec
to
f77f688
Compare
f77f688
to
393a74a
Compare
akerouanton
commented
Dec 7, 2018
- cd C:\tools\php | ||
- IF EXIST c:\tools\php (SET PHP=0) | ||
- ps: choco search php --exact --all-versions -r | ||
- ps: echo ((choco search php --exact --all-versions -r | select-string -pattern $env:php_ver_target | sort { [version]($_ -split '\|' | select -last 1) } -Descending | Select-Object -first 1) -replace '[php|]','') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep these two lines to debug what's going wrong next time builds on AppVeyor crash with no obvious reason.
nicolasmure
approved these changes
Dec 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.