Adds symfony/process to dependencies to avoid issues on Windows environment #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I tried to use this library on a Windows environment and encountered an issue with process execution. I got a "0" as exit status but nothing in stdout... I tried to debug and finally realised that a different behaviour was possible by installing
symfony/process
package. And it worked well with it.So, instead of try to deal with Windows environment in the embedded Process class, why not add it to the dependencies? (they already have some code for that: https://github.com/symfony/Process/blob/master/Process.php#L277)
I also think that it's not a good idea to provide two implementations of process execution with a silent configuration (by silent I mean
if (class_exists('Symfony\Component\Process\Process')) {}
), it doesn't ease the maintenance.