Removed validation of parameters

removed MissingArgumentException
KnpLabs · Mar 10, 2023 · cbf08fc · cbf08fc
1 parent 289c0ab
commit cbf08fc
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 24 deletions.
diff --git a/lib/Github/Api/Environment/Secrets.php b/lib/Github/Api/Environment/Secrets.php
@@ -3,7 +3,6 @@
 namespace Github\Api\Environment;
 
 use Github\Api\AbstractApi;
-use Github\Exception\MissingArgumentException;
 
 /**
  * @link https://docs.github.com/en/rest/actions/secrets?apiVersion=2022-11-28
@@ -45,20 +44,10 @@ public function show(int $id, string $name, string $secretName)
      * @param string $secretName
      * @param array  $parameters
      *
-     * @throws MissingArgumentException
-     *
      * @return array|string
      */
     public function createOrUpdate(int $id, string $name, string $secretName, array $parameters = [])
     {
-        if (!isset($parameters['encrypted_value'])) {
-            throw new MissingArgumentException(['encrypted_value']);
-        }
-
-        if (!isset($parameters['key_id'])) {
-            throw new MissingArgumentException(['key_id']);
-        }
-
         return $this->put('/repositories/'.$id.'/environments/'.rawurlencode($name).'/secrets/'.rawurlencode($secretName), $parameters);
     }
 

diff --git a/lib/Github/Api/Environment/Variables.php b/lib/Github/Api/Environment/Variables.php
@@ -3,7 +3,6 @@
 namespace Github\Api\Environment;
 
 use Github\Api\AbstractApi;
-use Github\Exception\MissingArgumentException;
 
 /**
  * @link https://docs.github.com/en/rest/actions/variables?apiVersion=2022-11-28
@@ -44,20 +43,10 @@ public function show(int $id, string $name, string $variableName)
      * @param string $name
      * @param array  $parameters
      *
-     * @throws MissingArgumentException
-     *
      * @return array|string
      */
     public function create(int $id, string $name, array $parameters)
     {
-        if (!isset($parameters['name'])) {
-            throw new MissingArgumentException(['name']);
-        }
-
-        if (!isset($parameters['value'])) {
-            throw new MissingArgumentException(['value']);
-        }
-
         return $this->post('/repositories/'.$id.'/environments/'.rawurlencode($name).'/variables', $parameters);
     }
 
@@ -69,8 +58,6 @@ public function create(int $id, string $name, array $parameters)
      * @param string $variableName
      * @param array  $parameters
      *
-     * @throws MissingArgumentException
-     *
      * @return array|string
      */
     public function update(int $id, string $name, string $variableName, array $parameters)