Support Symfony 7 #282
Support Symfony 7 #282
Conversation
|
Ok, i found my answer in .github-actions. Tests are passing locally. |
composer.json
Outdated
| "symfony/config": "^4.4|^5.0|^6.0", | ||
| "symfony/dependency-injection": "^4.4|^5.0|^6.0", | ||
| "symfony/http-kernel": "^4.4|^5.0|^6.0" | ||
| "name": "knplabs/knp-gaufrette-bundle", |
There was a problem hiding this comment.
all these changes in spaces need to be reverted
There was a problem hiding this comment.
Must revert space formatting from "license": "MIT", to "license": "MIT", too ?
There was a problem hiding this comment.
(wich json formatter is used ?)
There was a problem hiding this comment.
That's irrelevant, this PR is not about changing the format of the file.
I understand indeed that the format is probably not the most standard possible, but it should be changed in a different PR.
|
I still see lines where the only change is about spacing: please revert all of them |
|
By the way, Gaufrette dropped support for PHP 7.2 and 7.3 already, let's align with that. |
|
I missed, you can remove some compatibility check like : https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/DependencyInjection/FactoryConfiguration.php#L20-L26 or https://github.com/KnpLabs/KnpGaufretteBundle/blob/master/DependencyInjection/MainConfiguration.php#L36-L41 |
|
@Nek- if you have a little time, could you please have a look or how could we move forward here? Thanks! |
|
Hello, I have no right on this repository anymore. Sorry I can't help. Please reach KNPLabs. |
|
Maybe @KevinArtus? Just a wild guess by looking at the assignees |
|
Once done I will merge and create a release 😉 |
PHPUnit is not setted in dev requirements. How are you testing the project ?