Improvement/refactor configurable api gateway #67
Conversation
Co-Authored-By: Filip Artur Kowalski <filip.artur.kowalski@gmail.com>
mateuszgrab-cognifide
changed the base branch from
master
to
getting-started-2-0
mateuszgrab-cognifide
changed the base branch from
getting-started-2-0
to
master
| @@ -1,8 +1,8 @@ | |||
| --- | |||
| title: Configurable API gateway | |||
| author: marcinkp | |||
| author: mateuszgrab-cognifide | |||
There was a problem hiding this comment.
I am not sure we can change the author when we do some improvements. @mateuszgrab-cognifide: I hope you are not disappointed.
There was a problem hiding this comment.
Sure, understood, I've recovered original author.
| ```java | ||
| package io.knotx.example.payment.utils; | ||
|
|
||
| import io.vertx.core.json.JsonArray; | ||
| import io.vertx.core.json.JsonObject; | ||
|
|
||
| public final class ProvidersProvider { | ||
| public final class PaymentProvidersProcessor { |
There was a problem hiding this comment.
I liked this tricky name ;) Sure, change it.
There was a problem hiding this comment.
Can you please apply those changes in the example code.
There was a problem hiding this comment.
I will create dedicated PR for example code and will share PR link shortly.
| ports: | ||
| - "3000:8080" | ||
| networks: | ||
| - knotnet | ||
|
|
||
| knotx: | ||
| image: knotx-example/gateway-api:latest | ||
| image: knotx-example/api-gateway:latest |
| @@ -1,9 +1,9 @@ | |||
| --- | |||
| title: Configurable API gateway | |||
| author: marcinkp | |||
| author: mateuszgrab-cognifide | |||
There was a problem hiding this comment.
The same. Maybe we can specify here more authors?
There was a problem hiding this comment.
I haven't managed to find a way to specify two authors, I've recovered original author.
| @@ -0,0 +1,8 @@ | |||
| --- | |||
There was a problem hiding this comment.
This should stay here :)
| ports: | ||
| - "3000:8080" | ||
| networks: | ||
| - knotnet | ||
|
|
||
| knotx: | ||
| image: knotx-example/gateway-api:latest | ||
| image: knotx-example/api-gateway:latest |
There was a problem hiding this comment.
| image: knotx-example/api-gateway:latest | |
| image: knotx-example/composing-many-apis:latest |
There was a problem hiding this comment.
Can you please check other references to api-gateway - composing-many-apis ?
| ```java | ||
| package io.knotx.example.payment.utils; | ||
|
|
||
| import io.vertx.core.json.JsonArray; | ||
| import io.vertx.core.json.JsonObject; | ||
|
|
||
| public final class ProvidersProvider { | ||
| public final class PaymentProvidersProcessor { |
There was a problem hiding this comment.
Can you please apply those changes in the example code.
Fix remarks to PR
No description provided.