Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Deno shims #8

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

PonomareVlad
Copy link

@PonomareVlad PonomareVlad commented Jul 18, 2023

Proposed to remove Deno shims — grammyjs/conversations#82 (comment)

Test source

Closes #7

Copy link

@wojpawlik wojpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closes #7.

@KnorpelSenf what's the lightweight tag for?

oson/build.ts

Lines 47 to 50 in 0fe5862

const process = Deno.run({
cmd: ["git", "tag", version],
});
await process.status();

@KnorpelSenf
Copy link
Owner

I don't see why we should take web-compatible code, inject a bunch of weird things so it can run on Node, and then use the Node-compat mode of web runtimes?

@KnorpelSenf
Copy link
Owner

But then again, I care so little about what happens to the Node package, that I might as well merge. As long as the web-compatible Deno build is clean, I'm happy. Sorry, future self :)

@KnorpelSenf
Copy link
Owner

Closes #7.

@KnorpelSenf what's the lightweight tag for?

oson/build.ts

Lines 47 to 50 in 0fe5862

const process = Deno.run({
cmd: ["git", "tag", version],
});
await process.status();

It tags a new release

@PonomareVlad
Copy link
Author

PonomareVlad commented Aug 7, 2023

@KnorpelSenf This will happen.

Just exclude test sources (and polyfills for them) from npm package and it will be look cleaner 🙂

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@0fe5862). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main       #8   +/-   ##
=======================================
  Coverage        ?   95.11%           
=======================================
  Files           ?        3           
  Lines           ?      307           
  Branches        ?       68           
=======================================
  Hits            ?      292           
  Misses          ?       14           
  Partials        ?        1           

@KnorpelSenf
Copy link
Owner

@KnorpelSenf This will happen

What do you mean?

@PonomareVlad
Copy link
Author

PonomareVlad commented Aug 7, 2023

@KnorpelSenf This will happen

What do you mean?

Just exclude test sources (and polyfills for them) from npm package and it will be look cleaner 🙂

@KnorpelSenf
Copy link
Owner

In package.json?

Do you mean I should do it? Do you mean this PQ already does it? Do you mean that this would be something to solve in the future? Are you responding to anything I said? I can't quite follow tbh

@PonomareVlad
Copy link
Author

@KnorpelSenf I just woke up, I'm sorry, caffeine will work now and I'll add it to PQ 🙃

@PonomareVlad
Copy link
Author

PonomareVlad commented Aug 7, 2023

@KnorpelSenf If we disable test then got this result

This seems like simplest way to eliminate test sources (and shims for them), but if test step is important, then we need something else

Maybe we can run build in two iterations — first with test and second without it for minimize ?

Снимок экрана 2023-08-07 в 14 43 08

@wojpawlik
Copy link

https://github.com/denoland/dnt#denotest-only-shim

@KnorpelSenf annotated tags are supposed to be used fot releases

Copy link

@KnightNiwrem KnightNiwrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: https://t.me/grammyjs/155170

We cannot release a change that would break oson for all non-VercelEdge Node users.

Edit: Those classes have been made available in Node's global

@PonomareVlad
Copy link
Author

Maybe we need to pin minimal node version for reliability ?

@KnorpelSenf
Copy link
Owner

I had to do some adjustments which were partially included here. Could you resolve the conflicts? I'll get back to this after that.

@8549 8549 mentioned this pull request Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: (0 , util_1.promisify) is not a function
5 participants