Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle API tokens and JWT tokens separately in auth plugin #647

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

irony
Copy link
Contributor

@irony irony commented Feb 28, 2025

After examining the code, I found the issue in the auth plugin. The problem is in how the token is being verified. The
code is trying to verify API tokens using JWT verification, but these appear to be two different authentication
mechanisms.

  • Improved token verification logic by separating the handling of simple API tokens from JWT tokens.
  • Added a check to see if the token is a simple API token and, if so, set request.user to null and return early.
  • Simplified the error logging when no token is provided by removing unnecessary details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant