Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__SIGFUNC__ no longer default for Windows. __PRETTY__FUNCTION no longer default for gcc/clang #470

Merged
merged 5 commits into from
Nov 30, 2022

Conversation

KjellKod
Copy link
Owner

SIGFUNC no longer default for Windows, It has to be explicitly picked through CMAKE option

@KjellKod
Copy link
Owner Author

  1. Example output with PRETTY_FUNCTION:OFF (which is default) from examples/g2log-FATAL-sigsegv
INFO [main_sigsegv.cpp->tryToKillWithAccessingIllegalPointer:51]
  1. example output with PRETTY_FUNCTION:ON from examples/g3log-FATAL-sigsegv
// formatted for readability
INFO 
[main_sigsegv.cpp->
void example_fatal::tryToKillWithAccessingIllegalPointer(std::unique_ptr<std::string>):51]

template arguments are expanded.

  1. SIGFUNC no longer default for Windows, It has to be explicitly picked through CMAKE option

@@ -29,12 +29,11 @@
#include <string>
#include <functional>


#if defined(__GNUC__) // GCC extension compatible
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is easier to read if you look at the plain file rather than the diff

@KjellKod
Copy link
Owner Author

circleCI runs PRETTY_FUNCTION:ON and gitaction runs PRETTY_FUNCTION:OFF

@KjellKod KjellKod changed the title __SIGFUNC__ no longer default for Windows __SIGFUNC__ no longer default for Windows. __PRETTY__FUNCTION no longer default for gcc/clang Nov 30, 2022
@KjellKod
Copy link
Owner Author

__PRETTY_FUNCTION__ and __FUNCSIG__ were not used before #424

This PR makes sure that the previous default is still __FUNCTION__ while __PRETTY_FUNCTION__ and __FUNCSIG__ can be activated using CMake options.

@KjellKod KjellKod merged commit dbd3d74 into master Nov 30, 2022
@KjellKod KjellKod deleted the funcsig_only_as_cmake_option branch November 30, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant