Replace std::result_of with std::invoke_result #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendly0Fire
changed the title
|
Thanks. Before I merge this I need to creat a branch and release for “last release with C++14 support”. On your end, please update the CI configuration to work with your changes. Once the tests are working I’ll review this PR |
|
Any idea when this can be merged? |
|
Thanks for the reminder. I’ve planned to create the release w/tagging and review and this this PR this ongoing week |
KjellKod
requested changes
Dec 14, 2020
.vscode/settings.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++17 deprecates
std::result_of<T>and C++20 completely removes it from the spec in favor ofstd::invoke_result<T>, preventing compilation of g3log if using C++20-level features.This is the simplest fix which merely replaces all instances of the former with the latter, but it will break compilation on C++14 or older. It would also be possible to make an alias of these templates and use macro compile flags to preserve compatibility with C++14, but I wasn't sure if that would be necessary.
I also took the liberty to use the
*_tdeclarations which are much less verbose.