Fix compiler warnings and condition check improvements #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- loglevels.cpp - warns about double return if dynamic logging is on - crashhandler_unix.cpp - warns about unused variable
1. Make the condition check more "C++ intuitive" For example, people may do something like below: ```cpp // log the value if pointer is not null LOG_IF(DEBUG, ptr) << "value: " << ptr->val; ``` This would not work since `ptr != true`, and would possibly confuse them 2. Checking if log level is enabled first. If it's disabled, there's no need to evaluate the expression (which can be expensive)
KjellKod
requested changes
Nov 20, 2020
alvin-777
commented
Nov 23, 2020
KjellKod
reviewed
Nov 23, 2020
| @@ -145,17 +145,17 @@ namespace g3 { | |||
|
|
|||
|
|
|||
| // LOG(level) is the API for the stream log | |||
| #define LOG(level) if(!g3::logLevel(level)) {} else INTERNAL_LOG_MESSAGE(level).stream() | |||
| #define LOG(level) if (!g3::logLevel(level)) {} else INTERNAL_LOG_MESSAGE(level).stream() | |||
There was a problem hiding this comment.
Format change with my “space” change not yet removed
There was a problem hiding this comment.
This is the only place you didn't put a space after an if.
Are you sure that you want to keep it inconsistent with everywhere else?
There was a problem hiding this comment.
You are right. For this file. Leave this as is. Thanks for calling it out
KjellKod
reviewed
Nov 23, 2020
KjellKod
requested changes
Nov 23, 2020
KjellKod
approved these changes
Nov 24, 2020
alvin-777
added a commit
to alvin-777/g3log
that referenced
this pull request
Nov 25, 2020
Fix compiler warnings and condition check improvements (KjellKod#390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New/modified code must be backed down with unit test - preferably TDD style development)
All new/modified functionality should be backed up with API documentation (API.markdown or README.markdown)
Cross-Platform Testing
Testing Advice
Run Test Alternatives:
ctestctest -Vfor verbose outputmake testFix compiler warnings
Condition check improvements
Make the condition check more "C++ intuitive"(reverted)For example, people may do something like below:
This would not work since
ptr != true, and would possibly confuse themIf it's disabled, there's no need to evaluate the expression (which can be expensive)