fix issue with stacktrace_windows not allocating sufficient memory fo… #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r SYMBOL_INFO struct
KjellKod
reviewed
Feb 25, 2020
| @@ -120,7 +120,7 @@ namespace { | |||
| std::string lineInformation; | |||
| std::string callInformation; | |||
| if (SymFromAddr(GetCurrentProcess(), addr, &displacement64, symbol)) { | |||
| callInformation.append(" ").append({std::string(symbol->Name), symbol->NameLen}); | |||
There was a problem hiding this comment.
The reason append was used before and not the std:: constructor was that I was not 100% sure the symbol would not contain null characters. The append function which is almost identical to the constructor for these arguments declare that null characters are fine to add.
Are you sure that the symbol string will never have null characters? Is this documented?
https://en.cppreference.com/w/cpp/string/basic_string/append (see: 4)
There was a problem hiding this comment.
Ignore that. I see now that the declaration for std::string constructor (4) is identical.
https://en.cppreference.com/w/cpp/string/basic_string/basic_string
So this change is slightly better as it creates fewer copies (potentially)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r SYMBOL_INFO struct
We encountered an issue in a private code base where printing out the stack after an error would itself cause an access violation in debug builds on Windows. The issue ends up being that the SYMBOL_INFO struct was constructed with insufficient memory to store the symbol name, which far exceeded the allocated amount of memory.
The issue is resolved by allocating more stack memory to allow for the use of up to MAX_SYM_NAME characters in the name field.