Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mingw parse error #293

Merged
merged 2 commits into from
Jan 15, 2019
Merged

Mingw parse error #293

merged 2 commits into from
Jan 15, 2019

Conversation

ctapmex
Copy link
Contributor

@ctapmex ctapmex commented Dec 30, 2018

after build on mingw this code
LOGF(G3LOG_DEBUG, "[BaseEditor] newFirstLine=%zd, parseFrom=%d, parseTo=%d", firstLine, parseFrom, parseTo);
write in log
ERROR LOG MSG NOTIFICATION: Failure to successfully parse the message"[BaseEditor] newFirstLine=%zd, parseFrom=%d, parseTo=%d"

  1. fixed the order of logic operations
  2. removed extra checks. This functionality will not work on windows with/without gcc

@KjellKod KjellKod merged commit 1a010de into KjellKod:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants