fix: Fix compilation with node v12 by updating resemblejs #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lejs This change updates the resemblejs package from 3.1.0 to 3.2.3. The updated version uses a version of the canvas library that can compile with node v12.
thewtex
force-pushed
the
update-resemblejs-fix-for-node12
branch
from
2d42eea
to
609e4a7
Compare
|
@jmargeta thank you for contributing! 👏 👍 🌮 I reformatted your commit message to follow commitizen formatting and change from |
thewtex
approved these changes
Oct 28, 2019
|
🎉 This PR is included in version 11.7.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Fantastic, thank you @thewtex ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the resemblejs package from 3.1.0 to 3.2.3 and fixes VTK.js build with node v12.
The updated files come directly from running
npm install resemblejs@3.2.3(npm 6.11.3, node v12.11.1).See also:
rsmbl/Resemble.js#176