Skip to content

feat(Sources/Filters/General/PaintFilter/index.js): Return strokeBuffer promise from paint filter. #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2019
Merged

feat(Sources/Filters/General/PaintFilter/index.js): Return strokeBuffer promise from paint filter. #1211

merged 1 commit into from
Sep 18, 2019

Conversation

JamesAPetts
Copy link
Contributor

@floryst , this PR just returns a promise from endStroke that resolves to the strokeBuffer.

re #1207

@floryst
Copy link
Contributor

floryst commented Sep 17, 2019

Just some housekeeping: you can squash the eslint rule commit into your main commit. No need to record eslint style commits.

@JamesAPetts
Copy link
Contributor Author

Sure thing, ready when you are :).

@floryst floryst merged commit e6db3d9 into Kitware:master Sep 18, 2019
@jourdain
Copy link
Collaborator

🎉 This PR is included in version 11.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jourdain jourdain added the released Automated label label Sep 18, 2019
@JamesAPetts JamesAPetts mentioned this pull request Oct 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released Automated label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JamesAPetts @floryst @jourdain