Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Model Property idKeypath into idKeyPath. #123

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fummicc1
Copy link

What is chagend

  • This PR changed property name Model.idKeypath -> Model.idKeyPath

reference issue

#122

@CLAassistant
Copy link

CLAassistant commented Sep 14, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@djones6
Copy link
Contributor

djones6 commented Sep 24, 2019

As per my comment in #122, I don't think we'd want to break the API in this way. Perhaps this could be done in an additive (non-breaking) way, such that either idKeyPath or idKeypath will work?

@fummicc1
Copy link
Author

About the danger of breaking the API, I just did build (⌘ + B) and confirmed that is succeeded.
スクリーンショット 2019-09-24 19 37 33

This PR is very minimum change. so it might not be necessary! For your information!

@@ -110,7 +110,7 @@ class TestId: XCTestCase {

struct IdentifiedPerson: Model {
static var tableName = "People"
static var idKeypath: IDKeyPath = \IdentifiedPerson.id
static var idKeyPath: IDKeyPath = \IdentifiedPerson.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By breaking I mean like in this example.

Existing users of Kuery-ORM who have implemented a Model with an idKeypath property would find that the model no longer behaves as an identified model. They would have to update their code and rename the property to match the new name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants