Merge create method into constructor
#375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KittyGiraudel
approved these changes
Jul 1, 2022
| export type EventHandler = (node: Element, event?: Event) => void; | ||
| export type EventType = "show" | "hide" | "destroy" | "create"; | ||
|
|
||
| export class A11yDialog { | ||
| constructor(node: Element, targets?: Targets); | ||
|
|
||
| create(targets: Targets): A11yDialog; |
There was a problem hiding this comment.
Also this was wrong. targets no longer exists since v7.
| @@ -64,8 +55,6 @@ A11yDialog.prototype.create = function () { | |||
|
|
|||
| // Execute all callbacks registered for the `create` event | |||
| this._fire('create') | |||
|
|
|||
| return this | |||
There was a problem hiding this comment.
Yes, return this is implicit when we do a new operation, whether for this syntax or for proper es6 classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As it says on the tin. Also gets rid of a
Targetstype that is only referenced forcreateand wasn't being used bycreateanyway.Step two of work discussed in #373