Improved math expressions #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Things are in a better state, + - / * work now for basic const var = 5 <operator> 1 Though the current method I'm using to make the ast isn't really going to work for dealing with precedence rules so some refactoring is needed going forward
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Node that identifiers are working, call expressions are not, that's a TODO / * % + - are working both other things like exponent and logical operators are also not working. Recasting is the most important thing to implement next
Irev-Dev
commented
Jan 21, 2023
| @@ -1296,6 +1313,61 @@ export function findClosingBrace( | |||
| return findClosingBrace(tokens, index + 1, _braceCount, searchOpeningBrace) | |||
| } | |||
|
|
|||
| // function findOpeningBrace( | |||
There was a problem hiding this comment.
I ended not needing this, but might be useful in future, I danno maybe I should have just deleted it.
Irev-Dev
commented
Jan 21, 2023
| if (part.type === 'Literal') { | ||
| return part.value | ||
| } else if (part.type === 'Identifier') { | ||
| return programMemory.root[part.name].value | ||
| } else if (part.type === 'BinaryExpression') { |
There was a problem hiding this comment.
now works with expressions with more than a single operator 🎉
jessfraz
added a commit
that referenced
this pull request
Apr 12, 2024
# This is the 1st commit message: updates; Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #2: docs Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #3: remove descriptions Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #4: get snippet tests Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #5: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #6: more autocomplete tests Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #7: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #8: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #9: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #10: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #11: tab to end of snippets Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #12: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #13: updates Signed-off-by: Jess Frazelle <github@jessfraz.com> # This is the commit message #14: A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu) # This is the commit message #15: A snapshot a day keeps the bugs away! 📷🐛 (OS: ubuntu)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bit more to it than I was expecting, dealing with order and precedence was a little tricky but mostly works now.
There are a few quirks but the base is there.
resolves #5