Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KCL: Allow comments in CallExpressionKw #5381

Merged
merged 4 commits into from
Feb 13, 2025

Conversation

adamchalmers
Copy link
Collaborator

Before, this would not parse:

line(
  end = [44.09, 306.95],
  // tag this for later
  tag = $hello
)

@adamchalmers adamchalmers requested review from jtran and nrc February 13, 2025 21:02
Copy link

vercel bot commented Feb 13, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 13, 2025 11:04pm

Copy link

qa-wolf bot commented Feb 13, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
@adamchalmers adamchalmers merged commit f37fc35 into main Feb 13, 2025
35 checks passed
@adamchalmers adamchalmers deleted the achalmers/comments-in-kw-fn-calls branch February 13, 2025 23:18
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.85%. Comparing base (5d02a27) to head (7d6b6b0).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5381      +/-   ##
==========================================
+ Coverage   85.84%   85.85%   +0.01%     
==========================================
  Files          94       94              
  Lines       34506    34540      +34     
==========================================
+ Hits        29622    29655      +33     
- Misses       4884     4885       +1     
Flag Coverage Δ
wasm-lib 85.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants