-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type to KclValue::Number #5380
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😃
Looks like numeric negation is just about the only thing that propagates the type, but this is exciting!
There's a bit more than that - I spiked out some of the propagation between numbers and geometry too, but yeah there's a lot to do still |
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5380 +/- ##
==========================================
+ Coverage 85.84% 85.85% +0.01%
==========================================
Files 94 94
Lines 34506 34639 +133
==========================================
+ Hits 29622 29741 +119
- Misses 4884 4898 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Another step towards UoM types. Again, there are no user-visible changes here.
This PR adds a type to
KclValue::Number
. It initialises this for literals with either the specified of default units, but doesn't use it for any checking or conversion. I've done some of the low-hanging fruit of propagating the types, but mostly that is left for future work (as shown by the prevalence ofUnknown
).