Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementing naive array pop #4806

Merged
merged 68 commits into from
Jan 7, 2025

Merge branch 'main' into guptaarnav/array-pop

be27cd2
Select commit
Loading
Failed to load commit list.
Merged

implementing naive array pop #4806

Merge branch 'main' into guptaarnav/array-pop
be27cd2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 7, 2025 in 0s

85.84% (+0.01%) compared to 65edf17

View this Pull Request on Codecov

85.84% (+0.01%) compared to 65edf17

Details

Codecov Report

Attention: Patch coverage is 91.93548% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.84%. Comparing base (65edf17) to head (be27cd2).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/std/array.rs 85.71% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4806      +/-   ##
==========================================
+ Coverage   85.82%   85.84%   +0.01%     
==========================================
  Files          86       86              
  Lines       31005    31067      +62     
==========================================
+ Hits        26611    26668      +57     
- Misses       4394     4399       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.