Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't error on failure to fetch privacy settings #4799

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix: don't error on failure to fetch privacy settings #4799

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a69329
fix: dont error on failure to fetch privacy settings
TomPridham Dec 14, 2024
68fcc15
Add console warning when we ignore it
jtran Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/wasm-lib/src/wasm.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ pub async fn kcl_lsp_run(
let mut zoo_client = kittycad::Client::new(token);
zoo_client.set_base_url(baseurl.as_str());

// Check if we can send telememtry for this user.
// Check if we can send telemetry for this user.
let can_send_telemetry = match zoo_client.users().get_privacy_settings().await {
Ok(privacy_settings) => privacy_settings.can_train_on_data,
Err(err) => {
Expand All @@ -319,7 +319,8 @@ pub async fn kcl_lsp_run(
{
true
} else {
return Err(err.to_string().into());
web_sys::console::warn_1(&format!("Failed to get privacy settings: {err:?}").into());
false
}
}
};
Expand Down
Loading