Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: linux icon #4554

Closed
wants to merge 7 commits into from
Closed
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .github/workflows/build-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,7 @@ jobs:
out/*-arm64-win.exe
out/*-arm64-mac.dmg
out/*-arm64-linux.AppImage
out/*-arm64-linux.deb

- uses: actions/upload-artifact@v4
if: ${{ env.IS_RELEASE == 'true' }}
Expand All @@ -250,7 +251,7 @@ jobs:
out/*-x64-win.exe
out/*-x64-mac.dmg
out/*-x86_64-linux.AppImage

out/*-amd64-linux.deb

upload-apps-release:
runs-on: ubuntu-22.04
Expand Down Expand Up @@ -325,6 +326,8 @@ jobs:
--arg mac_x64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-x64-mac.dmg" \
--arg windows_arm64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-arm64-win.exe" \
--arg windows_x64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-x64-win.exe" \
--arg deb_arm64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-arm64-linux.deb" \
--arg deb_amd64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-amd64-linux.deb" \
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why, but instead of an x86 file, I get an amd64 file

--arg linux_arm64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-arm64-linux.AppImage" \
--arg linux_x64_url "$RELEASE_DIR/${{ env.URL_CODED_NAME }}-${VERSION_NO_V}-x86_64-linux.AppImage" \
'{
Expand All @@ -344,6 +347,12 @@ jobs:
"exe-x64": {
"url": $windows_x64_url
},
"deb-arm64" :{
"url": "$deb_arm64_url"
},
"deb-amd64" :{
"url": "$deb_amd64_url"
},
"appimage-arm64": {
"url": $linux_arm64_url
},
Expand Down
4 changes: 4 additions & 0 deletions electron-builder.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ linux:
arch:
- x64
- arm64
- target: deb
arch:
- x64
- arm64
fileAssociations:
- ext: kcl
name: kcl
Expand Down