KCL: More ways to reference paths #4387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
adamchalmers
force-pushed
the
achalmers/seg-end-fn
branch
from
593869c to
61d5527
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
==========================================
- Coverage 86.09% 86.09% -0.01%
==========================================
Files 78 78
Lines 27755 27829 +74
==========================================
+ Hits 23897 23959 +62
- Misses 3858 3870 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
adamchalmers
force-pushed
the
achalmers/seg-end-fn
branch
from
61d5527 to
7d70e96
Compare
adamchalmers
changed the title
adamchalmers
commented
Nov 4, 2024
| @@ -181,47 +181,39 @@ impl Args { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn make_user_val_from_json(&self, j: serde_json::Value) -> Result<KclValue, KclError> { | |||
| Ok(KclValue::UserVal(crate::executor::UserVal { | |||
| fn make_user_val_from_json(&self, j: serde_json::Value) -> KclValue { | |||
There was a problem hiding this comment.
I realized this function always returned Ok, so I removed the Result wrapper from the return type. That change cascaded through to some other functions.
jtran
reviewed
Nov 4, 2024
adamchalmers
force-pushed
the
achalmers/seg-end-fn
branch
from
1daa003 to
5969e02
Compare
jtran
approved these changes
Nov 5, 2024
adamchalmers
force-pushed
the
achalmers/seg-end-fn
branch
2 times, most recently
from
99a08fa to
e82ef5c
Compare
adamchalmers
force-pushed
the
achalmers/seg-end-fn
branch
from
e82ef5c to
6de8ee9
Compare
lf94
pushed a commit
that referenced
this pull request
Nov 5, 2024
Adds new stdlib functions segStart, segStartX, segStartY, segEnd Part of <#4382>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4382