Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement a simple startSketchOn / offsetPlane lint rule #4384

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Conversation

paultag
Copy link
Collaborator

@paultag paultag commented Nov 4, 2024

This won't do anything smart, but it will catch "obvious" uses of startSketchOn where an offsetPlane should be used instead.

Copy link

qa-wolf bot commented Nov 4, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Nov 5, 2024 6:08pm

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 84.61538% with 20 lines in your changes missing coverage. Please review.

Project coverage is 86.09%. Comparing base (aceb805) to head (27584b4).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
src/wasm-lib/kcl/src/lint/checks/offset_plane.rs 84.49% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4384      +/-   ##
==========================================
- Coverage   86.09%   86.09%   -0.01%     
==========================================
  Files          78       79       +1     
  Lines       27755    27885     +130     
==========================================
+ Hits        23897    24007     +110     
- Misses       3858     3878      +20     
Flag Coverage Δ
wasm-lib 86.09% <84.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paultag paultag requested review from jessfraz and adamchalmers and removed request for jessfraz November 5, 2024 15:36
@paultag
Copy link
Collaborator Author

paultag commented Nov 5, 2024

ok this is ready for review now

@paultag paultag merged commit 360384e into main Nov 5, 2024
30 of 32 checks passed
@paultag paultag deleted the paultag/sketchy branch November 5, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants