(ignore) yarn test:unit issues: sketchFromKclValue error with UserVal, update to He not wrapped in act(...) #4243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…modeling-app into kclvalue-got-userval
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
sorry, ignore this. |
guptaarnav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed some errors with
yarn test:unit.In MemoryPane, there were errors when trying to call sketchFromKclValue on a UserVal wrapping a Sketch. I saw there is discussion about overhauling KclValues in #1130, so this is likely a short-lived change, but it does seem to address the test failures that were previously happening from MemoryPane.test.tsx.
(apologies for the @ts_ignore, the KclValue autogenerated type def does not include type union with Function, even though a Function is fair game apparently and needs to be handled.)
Also fixed a minor error where tests were not properly awaiting changes to the tests for UserSidebarMenu.