Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show top level dir #4165

Merged
merged 10 commits into from
Oct 28, 2024
Merged

Show top level dir #4165

merged 10 commits into from
Oct 28, 2024

Conversation

lf94
Copy link
Contributor

@lf94 lf94 commented Oct 15, 2024

Show the top-level project directory name in the title bar of the file tree

@lf94 lf94 requested a review from franknoirot October 15, 2024 19:45
Copy link

vercel bot commented Oct 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Oct 28, 2024 4:58pm

Copy link

qa-wolf bot commented Oct 15, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just on change please, but this is great

src/components/ModelingSidebar/ModelingSidebar.tsx Outdated Show resolved Hide resolved
Base automatically changed from reload-file-tree to main October 18, 2024 03:42
@franknoirot
Copy link
Collaborator

I'm gonna add a PR description for posterity

@lf94 lf94 force-pushed the show-top-level-dir branch from 03140df to 78ea2cb Compare October 28, 2024 13:03
Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into my question and partially addressing it. I wish there were a better standard way to coerce a React Node to a series of strings for accessible names, but we can address this in a follow-up with an accessibleName ModelingPaneProps item

@lf94 lf94 merged commit 05610bb into main Oct 28, 2024
26 checks passed
@lf94 lf94 deleted the show-top-level-dir branch October 28, 2024 18:29
@franknoirot franknoirot mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants