KCL: Reduce can take and return any KCL values #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Previously it only took Array of Number and could only return Sketch. Now it has been unshackled from the chains of poor type signatures.
adamchalmers
force-pushed
the
achalmers/generalize-reduce
branch
from
dee483f to
14432ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4094 +/- ##
==========================================
+ Coverage 86.22% 86.25% +0.03%
==========================================
Files 75 75
Lines 26488 26484 -4
==========================================
+ Hits 22838 22845 +7
+ Misses 3650 3639 -11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtran
approved these changes
Oct 4, 2024
| | `array` | `[u64]` | | Yes | | ||
| | `start` | [`Sketch`](/docs/kcl/types/Sketch) | A sketch is a collection of paths. | Yes | | ||
| | `array` | [`[KclValue]`](/docs/kcl/types/KclValue) | | Yes | | ||
| | `start` | [`KclValue`](/docs/kcl/types/KclValue) | A memory item. | Yes | |
There was a problem hiding this comment.
I didn't realize A memory item., the doc comment of KclValue, was making it into the user-facing docs. We should probably improve that.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it only took Array of Number and could only return Sketch.
Now it has been unshackled from the chains of poor type signatures.