Add Warning Message for Fillet Engine Limitations in CommandBar #4076
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
…max-command-bar-multiple-fillet-selection
There was a problem hiding this comment.
Nice, just a couple comments. I think it was a good move to make this a simple string for now, and not a full ReactNode.
I can see this parameter becoming more general in the future, so that instead of warningMessage it's something like additionalInfo: { level: 'warning'; message: 'Fillets cannot touch other fillets yet. This is under development.' }, so we can have other message levels like info and destructive that result in different-styled components. But we shouldn't do that until we need it.
|
I agree with Frank's comments. I tested locally and it looks good. Glad it only shows up during the selection step. |
Co-authored-by: Frank Noirot <frank@zoo.dev>
This reverts commit ebfa8a0.
this issue is part of Fillet project: #2606
closes: #3833
Summary:
This PR adds a warning message to the CommandBar to inform users about current engine limitations with fillets (e.g., fillets cannot touch other fillets). The warning is visually distinct and aims to improve user awareness.
Changes:
Added
warningMessagetoCommandArgumenttype and integrated it into the UI.Future Enhancements:
The message will evolve to cover more fillet-related errors in the separate PRs, such as selecting already filleted edges, or engine fails on dry run : #2612
This is a first step toward improving user feedback for fillet operations.