Add menu item and hotkey to center view on current selection #4068
Conversation
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Jonathan Tran <jonnytran@gmail.com>
|
I'm tagging in to do the following:
|
|
my b on the log. i forgot to remove that |
|
Oh it's nothing at all, not to worry |
|
I think the last thing this needs is a bump to the |
franknoirot
changed the title
franknoirot
requested review from
lf94 and
nadr0
and removed request for
Irev-Dev and
jessfraz
|
Oh shit yes, first thing in the morning! |
| /** Forces a refresh of the camera position and target displayed | ||
| * in the debug panel and then returns the values of the fields | ||
| */ | ||
| async getCameraInfo() { |
There was a problem hiding this comment.
I love our new fixture stuff :')
| @@ -1,18 +1,18 @@ | |||
| import { test, expect } from '@playwright/test' | |||
|
|
|||
| import { _test, _expect } from './playwright-deprecated' | |||
There was a problem hiding this comment.
I mustve missed the memo - what's going on here? :)
There was a problem hiding this comment.
We'll undo this change in a separate PR per Slack discussion
| engineCommandManager | ||
| .sendSceneCommand({ | ||
| type: 'modeling_cmd_req', | ||
| cmd_id: uuidv4(), | ||
| cmd: { | ||
| type: 'default_camera_center_to_selection', | ||
| }, | ||
| }) | ||
| .catch(reportRejection) |
There was a problem hiding this comment.
IMO should be in the CameraControls file but we can refactor later!
There was a problem hiding this comment.
Oh yeah good idea, that's better
| import { test, expect } from '@playwright/test' | ||
|
|
||
| import { _test, _expect } from './playwright-deprecated' | ||
| import { test } from './fixtures/fixtureSetup' |
There was a problem hiding this comment.
Can we revert this name change and do something like
import { test, expect } from '@playwright/test'
import { test as fixtureSetupTest } from './fixtures/fixtureSetup'
I am confused to why we have a './playwright-deprecated' when we can just do alias importing?
There was a problem hiding this comment.
After talking with the team, you do not have to fix this within this PR. We can address this importing stuff on the web team. This pattern is fine within this file for this PR.
|
I'd guess that if you merge |
Prerequisites
@kittycad/libAdds a new modelingMachine event and action to send the new
default_camera_center_to_selectionengine command, and connects this event to themod + shift + chotkey and the view menu in the lower-right view controls