KCL: No 'let' or 'const' required when declaring vars #4063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
can you update the types doc its a manual doc of stuff like this in docs/kcl/types |
jtran
reviewed
Oct 1, 2024
Done! |
jtran
reviewed
Oct 1, 2024
jtran
reviewed
Oct 1, 2024
jtran
approved these changes
Oct 1, 2024
adamchalmers
force-pushed
the
achalmers/no-let-necessary
branch
2 times, most recently
from
64b2320 to
2250297
Compare
adamchalmers
commented
Oct 1, 2024
Just to test it works.
Also updates the Rust recaster tests.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4063 +/- ##
==========================================
+ Coverage 86.16% 86.21% +0.04%
==========================================
Files 75 75
Lines 26423 26454 +31
==========================================
+ Hits 22768 22806 +38
+ Misses 3655 3648 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The test was failing because 'myVar' could be found in two places, and it was told to just "click on 'myVar'". That wasn't ambiguous before when the code editor had `const myVar =` but now with the naked assignment, it is. Solution is to make it more specific and find 'myVar' in the code editor.
adamchalmers
force-pushed
the
achalmers/no-let-necessary
branch
2 times, most recently
from
fd28685 to
6102a7f
Compare
This was referenced Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously variable declaration required a keyword, e.g.
These were all valid, and did the exact same thing. As of this PR, they're all still valid, but the KCL formatter will change them all to just:
which is the new preferred way to declare a constant.
Screenshots demonstrate that
let,const,varand naked declarations all work:But the formatter will remove the var/let/const keywords.
Closes #3985