Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mouse controls display to be easier to understand #3648

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

jtran
Copy link
Collaborator

@jtran jtran commented Aug 23, 2024

Resolves #3095.

No functionality change, just different UI labels.

  • OS → Win/Super/Cmd
  • Alt → Alt/Option
  • Scroll wheel → Scroll

"Right-click drag" is a single gesture to me, so I find it easier to read "{modifier} + {gesture}". Using a mouse, first, the non-dominant hand presses the modifier key(s), and then the dominant hand does the dragging gesture.

Contrast this with "Right click + {modifier} + drag". I need to mentally combine "Reft click" and "drag", and re-order the modifier press first. Then drag with the Right button.


Windows

Screenshot 2024-08-26 at 1 48 11 PM

Linux

Screenshot 2024-08-26 at 1 48 30 PM

macOS

Screenshot 2024-08-23 at 6 22 35 PM

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 26, 2024 5:59pm

Copy link
Collaborator

@franknoirot franknoirot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A welcome change! I think you could go a tiny bit further as noted in my comment, but leave it up to you to decide.

src/lib/cameraControls.ts Outdated Show resolved Hide resolved
@jtran jtran marked this pull request as ready for review August 26, 2024 17:49
@jtran jtran merged commit 972dca8 into main Aug 26, 2024
24 checks passed
@jtran jtran deleted the jtran/mouse-control-keys branch August 26, 2024 19:05
@pierremtb pierremtb mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention of "OS" should be actual OS specific key
2 participants