Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the last windows test not passing #3644

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
19 changes: 15 additions & 4 deletions e2e/playwright/testing-settings.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,6 @@ test.describe('Testing settings', () => {
`Project settings override user settings on desktop`,
{ tag: '@electron' },
async ({ browser: _ }, testInfo) => {
test.skip(
process.platform === 'win32',
'TODO: remove this skip https://github.com/KittyCAD/modeling-app/issues/3557'
)
const { electronApp, page } = await setupElectron({
testInfo,
folderSetupFn: async (dir) => {
Expand Down Expand Up @@ -276,11 +272,26 @@ test.describe('Testing settings', () => {
await expect(logoLink).toHaveCSS('--primary-hue', userThemeColor)
await settingsCloseButton.click()
})
let screenshot = await page.screenshot()
await testInfo.attach('screenshot1', {
body: screenshot,
contentType: 'image/png',
})

await test.step('Set project theme color', async () => {
// Open the project
await projectLink.click()
screenshot = await page.screenshot()
await testInfo.attach('screenshot2', {
body: screenshot,
contentType: 'image/png',
})
await settingsOpenButton.click()
screenshot = await page.screenshot()
await testInfo.attach('screenshot3', {
body: screenshot,
contentType: 'image/png',
})
// The project tab should be selected by default within a project
await expect(projectSettingsTab).toBeChecked()
await themeColorSetting.fill(projectThemeColor)
Expand Down
Loading