Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hollow #3642

Merged
merged 3 commits into from
Aug 23, 2024
Merged

add hollow #3642

merged 3 commits into from
Aug 23, 2024

Conversation

jessfraz
Copy link
Contributor

No description provided.

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

vercel bot commented Aug 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 23, 2024 4:19pm

Copy link

qa-wolf bot commented Aug 23, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 93.10345% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.91%. Comparing base (2fde712) to head (58abed0).
Report is 5 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/std/shell.rs 93.10% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3642   +/-   ##
=======================================
  Coverage   87.90%   87.91%           
=======================================
  Files          67       67           
  Lines       26076    26105   +29     
=======================================
+ Hits        22923    22950   +27     
- Misses       3153     3155    +2     
Flag Coverage Δ
wasm-lib 87.91% <93.10%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz enabled auto-merge (squash) August 23, 2024 16:40
@jessfraz jessfraz merged commit 4dfad19 into main Aug 23, 2024
30 checks passed
@jessfraz jessfraz deleted the bump-kittycad branch August 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant