Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nadro/3581/change base unit test #3621

Merged
merged 14 commits into from
Aug 24, 2024
Merged

Nadro/3581/change base unit test #3621

merged 14 commits into from
Aug 24, 2024

Conversation

nadr0
Copy link
Collaborator

@nadr0 nadr0 commented Aug 22, 2024

closes #3581

  • I updated the README.md with more details on how to setup playwright for the web tests. I ran into a few gotchas.
  • I added E2E tests for the scenarios in the issue above.
    • Command bar -> Project level -> all units
    • Gizmo -> Project level -> all units
    • Settings -> Project level -> all units
    • Settings -> User level -> all units

@nadr0 nadr0 linked an issue Aug 22, 2024 that may be closed by this pull request
Test: there are three different ways to change units, make sure all are tested and re-execute model only once #3581
Closed
@qa-wolf QA Wolf
Copy link

qa-wolf bot commented Aug 22, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Aug 24, 2024 10:41pm

@jessfraz
Copy link
Contributor

so close! everthing passed except lint :)

@jessfraz jessfraz enabled auto-merge (squash) August 24, 2024 22:42
@jessfraz jessfraz merged commit fbf0d3d into main Aug 24, 2024
24 checks passed
@jessfraz jessfraz deleted the nadro/3581/change-base-unit-test branch August 24, 2024 23:51
@github-actions github-actions bot mentioned this pull request Aug 26, 2024
Merged
@pierremtb pierremtb mentioned this pull request Sep 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test: there are three different ways to change units, make sure all are tested and re-execute model only once
2 participants
@nadr0 @jessfraz