Enable all disabled win32 tests #3618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
iterion
force-pushed
the
iterion/rm-windows-skips
branch
from
fe33b64 to
962ae19
Compare
|
okay i merged in main and its just this one one windows electron: |
iterion
force-pushed
the
iterion/rm-windows-skips
branch
from
a35fdc8 to
131a193
Compare
|
And the one that's failing passes on my windows machine! Not sure yet why CI is special. |
iterion
force-pushed
the
iterion/rm-windows-skips
branch
from
131a193 to
4e2c375
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covers most of #3557
One test still not passing in CI but does work on my local. I'm trying to reproduce so I can fix but I'll do that in a separate PR.