Fail playwright tests when console errors exists #3345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
approved these changes
Aug 13, 2024
|
Been trying to merge this for last couple of days now, seems every time I pull latest from main bunch of other things break. Going to keep trying till I get all check passing |
…onsole-errors-exists
|
Sorry I forgot about this should have got it merged but not lots of things are failing, probably because there are new error. I can look at getting the list updating and getting it merged. |
jtran
reviewed
Aug 22, 2024
There was a problem hiding this comment.
In the future, consider using the terms "allow list" and "block list" instead of "white list" and "black list".
…onsole-errors-exists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
awaitsIf this gets super annoying, we can disable it via setting
FAIL_ON_CONSOLE_ERRORSto false inplaywright.yml, but yeah ideally it'd be good to have a cursory glance at these errors just incase they're legit.