Fix tanArcTo #3318
Merged
Fix tanArcTo #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
adamchalmers
commented
Aug 7, 2024
|
|
||
| *to | ||
| args.batch_modeling_cmd(id, tan_arc_to(&sketch_group, &to)).await?; | ||
| // TODO: Figure out these calculations. |
There was a problem hiding this comment.
We didn't fix the tangentialArc function for this case, because we think it should be removed. See #3319
JordanNoone
approved these changes
Aug 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3318 +/- ##
==========================================
+ Coverage 87.63% 87.84% +0.21%
==========================================
Files 66 66
Lines 25369 25399 +30
==========================================
+ Hits 22231 22313 +82
+ Misses 3138 3086 -52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Irev-Dev
approved these changes
Aug 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JordanNoone discovered a bug in KCL's
tangentialArcTostdlib function. We fixed it together.While fixing this, we discovered the tangentialArc API is kinda weird, and filed #3319 for it.