Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal linter for making sure everything is camel case #3172

Merged
merged 8 commits into from
Jul 29, 2024

Conversation

jessfraz
Copy link
Contributor

@jessfraz jessfraz commented Jul 29, 2024

closes #1899

right now this is backwards incompatible but we should remove the backwards incompatibilty in the future.

  • external linter rule to tell people to change the object properties

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

qa-wolf bot commented Jul 29, 2024

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Jul 29, 2024 7:53pm

Signed-off-by: Jess Frazelle <github@jessfraz.com>
@jessfraz jessfraz changed the title linter for making sure everything is camel case internal linter for making sure everything is camel case Jul 29, 2024
jessfraz and others added 6 commits July 29, 2024 12:11
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Signed-off-by: Jess Frazelle <github@jessfraz.com>
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 82.14286% with 10 lines in your changes missing coverage. Please review.

Project coverage is 87.89%. Comparing base (67d0fb7) to head (c4f13f2).
Report is 6 commits behind head on main.

Files Patch % Lines
src/wasm-lib/kcl/src/lint/checks/std_lib_args.rs 60.00% 8 Missing ⚠️
src/wasm-lib/kcl/src/docs.rs 77.77% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3172      +/-   ##
==========================================
- Coverage   87.93%   87.89%   -0.05%     
==========================================
  Files          66       66              
  Lines       25008    25071      +63     
==========================================
+ Hits        21992    22037      +45     
- Misses       3016     3034      +18     
Flag Coverage Δ
wasm-lib 87.89% <82.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jessfraz jessfraz enabled auto-merge (squash) July 29, 2024 20:17
@jessfraz jessfraz merged commit a1c2e81 into main Jul 29, 2024
22 of 24 checks passed
@jessfraz jessfraz deleted the line-camel-case branch July 29, 2024 20:18
@franknoirot franknoirot mentioned this pull request Jul 30, 2024
jessfraz added a commit that referenced this pull request Jul 31, 2024
* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* add lint rule for object property key

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* add linter to example shit

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* fix samples

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* fix lints

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* updates

Signed-off-by: Jess Frazelle <github@jessfraz.com>

* generate docs

Signed-off-by: Jess Frazelle <github@jessfraz.com>

---------

Signed-off-by: Jess Frazelle <github@jessfraz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal linter for kcl functions
1 participant