-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Fix bad network until a project is opened #2661
Conversation
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2661 +/- ##
==========================================
+ Coverage 86.54% 87.51% +0.96%
==========================================
Files 60 56 -4
Lines 22823 22191 -632
==========================================
- Hits 19752 19420 -332
+ Misses 3071 2771 -300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
<ModelingMachineProvider> | ||
<Outlet /> | ||
<Home /> | ||
<CommandBar /> | ||
</ModelingMachineProvider> | ||
<WasmErrBanner /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed that this does the trick only when you open the app signed in. Works after a refresh after signing in, which is probably why the test fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah forcing a refresh after auth makes the test happy.
@lf94 @franknoirot The way I tried to enable the engine connection on the home page here was a complete shot in the dark. Let me know how you'd want to proceed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, sorry for the dirty diff here. We should merge #2659 first
I can check this when Im home in 3hr. Still wip? |
Well yeah still wip cause I have no idea if it’s the right solution, nor does it work first time after sign inOn Jun 16, 2024, at 4:59 PM, 49fl ***@***.***> wrote:
I can check this when Im home in 3hr. Still wip?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Just merged #2659! |
@franknoirot Thank you! Updating |
Is this work still ongoing, or maybe we figured it was the wrong approach? |
@Irev-Dev Not sure about the approach but I think we should keep the test. Kicking a branch update now |
closed this was fixed elesewhere |
Will fix #2610 and add tauri e2e test to check on the network indicator.
Merge #2659 first