test exports #1139
Merged
test exports #1139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Irev-Dev
commented
Nov 28, 2023
Comment on lines
+265
to
+287
| // the following exports are failing | ||
| // await doExport({ | ||
| // type: 'ply', | ||
| // storage: 'ascii', | ||
| // coords: sysType, | ||
| // }) | ||
| // await doExport({ | ||
| // type: 'ply', | ||
| // storage: 'binary' as unknown as 'binary_little_endian', | ||
| // coords: sysType, | ||
| // }) | ||
| // await doExport({ | ||
| // type: 'stl', | ||
| // storage: 'ascii', | ||
| // coords: sysType, | ||
| // units: 'in', | ||
| // }) | ||
| // await doExport({ | ||
| // type: 'stl', | ||
| // storage: 'binary', | ||
| // coords: sysType, | ||
| // units: 'in', | ||
| // }) |
Irev-Dev
commented
Nov 28, 2023
| if ( | ||
| supportsFileSystemAccess && | ||
| window.showSaveFilePicker && | ||
| !(window as any).playwrightSkipFilePicker |
There was a problem hiding this comment.
This is a bit of a hack for sure, but I can't test the exports without skipping the file picker since that's OS stuff and outside of playwright control.
Irev-Dev
commented
Nov 28, 2023
| // FYI this test doesn't work with only engine running locally | ||
| const u = getUtils(page) | ||
| await context.addInitScript(async () => { | ||
| ;(window as any).playwrightSkipFilePicker = true |
There was a problem hiding this comment.
Other half of the playwrightSkipFilePicker hack.
35 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #833
Tests have been put into the snapshot test suite because like images, it commits the export outputs, so if see a step,gltf,etc diff in a PR, double check it was intentional.