Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump kcl libraries #1049

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Bump kcl libraries #1049

merged 2 commits into from
Nov 25, 2024

Conversation

adamchalmers
Copy link
Contributor

No description provided.

@adamchalmers adamchalmers requested a review from nrc November 25, 2024 22:01
Copy link
Contributor

@nrc nrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.21%. Comparing base (99ad579) to head (a57b751).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/context.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   72.24%   72.21%   -0.03%     
==========================================
  Files          36       36              
  Lines        6647     6640       -7     
==========================================
- Hits         4802     4795       -7     
  Misses       1845     1845              
Flag Coverage Δ
unittests 72.21% <96.55%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamchalmers adamchalmers merged commit 55bd709 into main Nov 25, 2024
8 checks passed
@adamchalmers adamchalmers deleted the achalmers/bump-kcl branch November 25, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants