Skip to content
This repository has been archived by the owner on Feb 13, 2025. It is now read-only.

MLIBZ-2517: Use correct query filter to delete multiple entities when using Server Side Delta Set #297

Merged

Conversation

thomasconner
Copy link
Contributor

Steps to reproduce:

  1. Enable deltaset
  2. Create 5 items
  3. Pull - there are now 5 items in cache
  4. Delete 3 items
  5. Pull - the request returns 3 items in deleted array
  6. Check cached collection

Expected result

The 3 items deleted from the server are deleted in the cached collection.

Actual result:

The items are still present in the cached collection.

Changes

  • Use contains() instead of containsAll() for delete query
  • Add integration test

@thomasconner thomasconner self-assigned this May 21, 2018
@thomasconner thomasconner requested a review from tejasranade May 21, 2018 20:45
@thomasconner thomasconner requested review from vinaygahlawat and removed request for tejasranade May 22, 2018 14:53
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasconner thomasconner merged commit 824a312 into master May 22, 2018
@thomasconner thomasconner deleted the mhristov/MLIBZ-2517-tests-for-mulutple-deleted-items branch May 22, 2018 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants