-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use timestamp to communicate collection_timestamp of the parent #1770
Conversation
Don't re-use old self.timestamp when notifying of event. Instead, re-compute it fresh. Fixes Kinto#1769.
Another approach would be to turn the Running the test suite with @leplatrem suggested that I add a comment to this change explaining it, which I'll do. |
Thanks @leplatrem for the suggestion.
1ab7209
to
2ec091b
Compare
I just added one test (for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks correct to me ;)
I'm not sure it's a clear indicator, since most of the test use the memory backend. Some load test maybe more accurate, but again with PG on the same machine I don't know if the difference will be huge. |
Hello https://github.com/property and https://github.com/reify ✋ |
OK. I am going to merge just this smaller fix, knowing that perhaps it isn't the best long-term solution, but right now I don't want to untangle the significance of the timestamp property being |
Don't re-use old self.timestamp when notifying of event. Instead,
re-compute it fresh.
Fixes #1769.
kinto.tpl
file with it.