Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bin/build.sh to support local builds #16

Closed
zemackdaddy opened this issue Sep 25, 2022 · 7 comments
Closed

Update bin/build.sh to support local builds #16

zemackdaddy opened this issue Sep 25, 2022 · 7 comments

Comments

@zemackdaddy
Copy link

zemackdaddy commented Sep 25, 2022

I noticed that you deleted lines in .github/workflows/build.yml but not in bin/build.sh.

I can build locally (mac) and the left firmware is in the zephyr folder but not as the name in bin/build.sh without removing the "matching" lines in bin/build. But the contents of the build/left/zephyr folder are that of my left build.

Doesn't it make sense to remove it in that file as well?

`#!/usr/bin/env bash

set -e

PWD=$(pwd)
TIMESTAMP=$(date -u +"%Y%m%d%H%M%S")

# West Build (left)
west build -s zmk/app -d build/left -b adv360_left -- -DZMK_CONFIG="${PWD}/config"
# Adv360 Left DTS File
# remove this cat -n build/left/zephyr/adv360_left.dts.pre.tmp
# Adv360 Left Kconfig file
cat build/left/zephyr/.config | grep -v "^#" | grep -v "^$"
# West Build (right)
west build -s zmk/app -d build/right -b adv360_right -- -DZMK_CONFIG="${PWD}/config"
# Adv360 Right DTS File
# remove this cat -n build/right/zephyr/adv360_right.dts.pre.tmp
# Adv360 Right Kconfig file
cat build/right/zephyr/.config | grep -v "^#" | grep -v "^$"
# Rename zmk.uf2
cp build/left/zephyr/zmk.uf2 ./firmware/${TIMESTAMP}-left.uf2 && cp build/right/zephyr/zmk.uf2 ./firmware/${TIMESTAMP}-right.uf2
`

@ReFil
Copy link
Collaborator

ReFil commented Sep 25, 2022

Which branch are you using?

@zemackdaddy
Copy link
Author

V2-beta

This references the paths you removed in .github/workflows/build.yml

@zemackdaddy
Copy link
Author

updated my original comment above. Apologies. This is all a bit new.

@zemackdaddy
Copy link
Author

My repo

For context, I split setup.sh into two files. I also split Dockerfile.
I modified the process so that I run a setup–zmk.sh to prepare the base image.
I then run setup-build.sh followed by run-local.sh to pull in my local changes and build locally.

The important part is that run-local.sh if I don't comment out the same cat statements you removed in the yaml file here.

My local build will fail in the same manner if I just run setup.sh and run.sh.

So since you modified a file that removes the cat statements, I thought maybe they should also be removed in the build script?

@ReFil
Copy link
Collaborator

ReFil commented Sep 25, 2022

Ah I understand now. Yes, that makes sense now. My apologies I didn't do the local building stuff. Will make those fixes asap, thank you for bringing this to my attention

@zemackdaddy
Copy link
Author

I'm glad I saw your changes. I was stumped!

@ReFil
Copy link
Collaborator

ReFil commented Oct 7, 2022

Closing as has been fixed

@ReFil ReFil closed this as completed Oct 7, 2022
jonatan-branting pushed a commit to jonatan-branting/Adv360-Pro-ZMK that referenced this issue Feb 1, 2024
# This is the 1st commit message:

Updated keymap
# The commit message KinesisCorporation#2 will be skipped:

# Updated keymap

# The commit message KinesisCorporation#3 will be skipped:

# feat: Add basic changes to make me feel more at home

# The commit message KinesisCorporation#4 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#5 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#6 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#7 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#8 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#9 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#10 will be skipped:

# Reduce brightness of leds

# The commit message KinesisCorporation#11 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#12 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#13 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#14 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#15 will be skipped:

# Updated adv360.keymap

# The commit message KinesisCorporation#16 will be skipped:

# Updated adv360.keymap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants