Add configuration option to ignore DNS RCODE 3 as errors #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <127646431+YDMsama@users.noreply.github.com>
|
Please add TestCase for TestDnsProtocol() in network_analyzer_test |
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <ydmsama@gmail.com>
hocktea214
approved these changes
Aug 30, 2023
dxsup
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces a new configuration option ignore_dns_rcode3_error that allows users to specify whether DNS responses with RCODE 3 (Name Error) should be treated as errors or not.
Motivation and Context
In Kubernetes clusters using the ClusterFirst DNS policy, KubeDNS may return RCODE 3 for public domains, which are usually treated as errors. This behavior may lead to unnecessary alerts and logging, especially when users are aware of this behavior and do not consider it an error.
How Has This Been Tested?
The compiled image runs normally.
After setting the ignore_dns_rcode3_error configuration to true and running the dig nonexistentsubdomain.dns3test.com command, the absence of trace metrics in Kindling indicates that the configuration change is effective and DNS queries with an RCODE of 3 are no longer considered errors.