Set default values of store_external_src_ip and StoreExternalSrcIP to false #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <ydmsama@gmail.com>
dxsup
previously approved these changes
Aug 16, 2023
Signed-off-by: YDMsama <ydmsama@gmail.com>
Signed-off-by: YDMsama <127646431+YDMsama@users.noreply.github.com>
dxsup
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change ensures that unexpected topologies are not generated by default when these settings are not explicitly enabled.
Related Issue
This PR addresses the issue discussed in:
#561
#187
Motivation and Context
By setting the default value to False, we aim to prevent these unexpected recordings unless the user explicitly opts in.
How Has This Been Tested?
The compiled image works properly.